feat: display arguments values in input nodes in run view #1612
+56
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
4 tasks
This was referenced Jan 12, 2026
camielvs
reviewed
Jan 13, 2026
Comment on lines
+119
to
+131
| isDefault ? ( | ||
| <InlineStack gap="1" className="ml-2"> | ||
| <Icon | ||
| name="SquareCheckBig" | ||
| size="sm" | ||
| className="text-muted-foreground" | ||
| /> | ||
|
|
||
| <Paragraph tone="subdued" size="xs"> | ||
| Use as default | ||
| </Paragraph> | ||
| </InlineStack> | ||
| ) : null |
Collaborator
There was a problem hiding this comment.
A little rusty after the break but does isDefault && (<Component />) work instead of a full ternary?
camielvs
reviewed
Jan 13, 2026
| placeholder={placeholder} | ||
| disabled={disabled} | ||
| inputName={input.name} | ||
| isDefault={!argumentValue || argumentValue === defaultInputValue} |
Collaborator
There was a problem hiding this comment.
For tidiness maybe extract this into a variable.
camielvs
approved these changes
Jan 13, 2026
Collaborator
camielvs
left a comment
camielvs
left a comment
There was a problem hiding this comment.
I wonder if just the "Use as Default" checkmark is sufficient as a differentiator. It is rather subtle. For values that come from external sources maybe we need a specific icon/info text for that? e.g. "Value provided externally" or something like that
4 tasks
maxy-shpfy
changed the base branch from
01-09-feat_display_taskspec_arguments_values_in_run_view
to
graphite-base/1612
maxy-shpfy
force-pushed
the
01-09-feat_display_arguments_values_in_input_nodes_in_run_view
branch
from
e19e404 to
3612180
Compare
maxy-shpfy
force-pushed
the
graphite-base/1612
branch
from
4435eaf to
c5adfbb
Compare
maxy-shpfy
force-pushed
the
01-09-feat_display_arguments_values_in_input_nodes_in_run_view
branch
from
3612180 to
e662951
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes https://github.com/Shopify/oasis-frontend/issues/414
Added support for displaying task arguments in the IO Node and Input Value Editor. This enhancement allows users to see when a pipeline input has been overridden with an argument value, clearly indicating when a value is not the default.
Type of Change
Checklist
Test Instructions
Screen Recording 2026-01-09 at 4.59.02 PM.mov (uploaded via Graphite)
Additional Comments
This change extracts the
getArgumentValuefunction into a separate utility file for reuse and adds conditional rendering of the "Use as default" indicator based on whether the current value is an argument override.